Conversation
…from NOTE to ERROR
There was a problem hiding this comment.
@vy
Does plugins.adoc need a change too? It still describes the notes as on by default.
Changing the default instead of removing the notes keeps the option useful for people who still want them, and notesSuppressedByDefaultWithoutAffectingMetadataGeneration shows the descriptor files are still written.
One thing has no line to comment on. The collapsible block in plugins.adoc, "Suppressing annotation processor notes in strict build environments", still says both processors emit NOTE-level diagnostics by default and that this option turns them off, and it lists NOTE (default) among the accepted values. The Maven and Gradle snippets under it pass =WARNING, which suppresses nothing now.
CI also failing because of spotless not applied correctly.
@ramanathan1504, good call. Fixed in 5402ef3. |
@ramanathan1504, right. Fixed in d1a559a. |
ramanathan1504
left a comment
ramanathan1504
left a comment
There was a problem hiding this comment.
One small thing left inline on the plugins.adoc title. Thanks 🙏
| @@ -218,12 +218,11 @@ Provide these values to the processor using the `log4j.graalvm.groupId` and `log | |||
| .Suppressing annotation processor notes in strict build environments | |||
There was a problem hiding this comment.
Title still says suppressing, but this now turns notes on
| .Suppressing annotation processor notes in strict build environments | |
| .Enabling annotation processor notes |
2 participants
Fixes #4225